change db pattern #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| I am currently wondering if it's a good idea at all to have this "create_postgresql_engine" function in bbsqla. In fact, isn't it better to just use sqlalchemy.create_engine? Having a specific PG option in a create_POSTGRESQL_engine function does not shock me, but I'm wondering if this is not a bit out of scope for the extension, what do you think? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I think passing client_encoding=utf8 in create_postgresql_engine() directly no a good solution, client_encoding is for postgres, so if you use mysql or any thing else..., it won"t work