[PR #13176/b4009b31 backport][8.3.x] Add readline workaround for libedit #13187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=80&v=4){kind=small}
× Failed to build `pydantic-core==2.18.2` error: failed to run custom build command for `pyo3-ffi v0.21.1` error: the configured Python interpreter version (3.13) is newer than PyO3's maximum supported version (3.12)I'll click “rebase”. |
* Add readline workaround for libedit We had a very similar workaround before for pyreadline, which had a similar issue: - Introduced in #1281 - Removed in #8848 for #8733 and #8847 This technically will regress the issues above, but those issues just mean that `import readline` is broken in general, so the user should fix it instead (by e.g. uninstalling pyreadline). Fixes #12888 Fixes #13170 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Handle no readline on Windows --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit b4009b3)
webknjaz force-pushed the patchback/backports/8.3.x/b4009b31978053fe077a32d219ad947a5ba7243c/pr-13176 branch from 95bd057 to b75cfb1 Compare 
webknjaz approved these changes Feb 28, 2025
webknjaz deleted the patchback/backports/8.3.x/b4009b31978053fe077a32d219ad947a5ba7243c/pr-13176 branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #13176 as merged into main (b4009b3).
We had a very similar workaround before for pyreadline, which had a similar issue:
This technically will regress the issues above, but those issues just mean that
import readlineis broken in general, so the user should fix it instead (by e.g. uninstalling pyreadline).Fixes #12888
Fixes #13170