Skip to content

Conversation

@RC2208
Copy link
Contributor

@RC2208 RC2208 commented Jul 14, 2021

Related Issue

  • Info about the related issue

  • DevIncept Participant

  • Contributor

Closes: #42

Describe the changes you've made

Added code for encryption and decryption of text using transposition cipher.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manually run and tested

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added test cases that prove my fix is effective or that my feature works.
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done:
Check it here with the README template. Check if you had added up everything or not, you will know the changes yourself.
And also the image links you had added in "README.md" file are of user-images content instead it should be the file path of the images present in this repo.

Kindly address these changes. @RC2208

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yayy, your PR is approved. Congrats on your first PR. Great start. Keep it up. ✨🎉👏@RC2208

@RC2208
Copy link
Contributor Author

RC2208 commented Jul 14, 2021

I have done the changes requested.

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to repo. Congrats on your PR. It's approved. Yay. Well done. Great start. ✨🎉👏@RC2208

@prathimacode-hub prathimacode-hub added DCP21 This issue will be considered for DCP21 🟩 Level1 This issue will be considered as level 1 issue for DevIncept 21.Points will be 10 labels Jul 14, 2021
@prathimacode-hub prathimacode-hub merged commit 7001ba3 into prathimacode-hub:main Jul 14, 2021
@welcome
Copy link

welcome bot commented Jul 14, 2021

Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️

@RC2208
Copy link
Contributor Author

RC2208 commented Jul 14, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DCP21 This issue will be considered for DCP21 🟩 Level1 This issue will be considered as level 1 issue for DevIncept 21.Points will be 10

2 participants