Skip to content

Conversation

@photon149
Copy link
Contributor

@photon149 photon149 commented Jul 13, 2021

  • Info about the related issue

  • DevIncept Participant

  • Contributor

Closes: #41 number that will be closed through this PR

Describe the changes you've made

The aim was to Caesar_Cipher problem. The code is running and is working perfectly.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manually Run and Tested

Describe how have you verified the changes made

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added test cases that prove my fix is effective or that my feature works.
@prathimacode-hub prathimacode-hub added the DCP21 This issue will be considered for DCP21 label Jul 13, 2021
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the project structure given. It's not in right format. @photon149

@photon149
Copy link
Contributor Author

Please Review once. I have made some changes.

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I said you to follow the project structure as well.
Changes to be done:
The project folder should be titled as "Caesar Cipher"
The project file should be as "caesar_cipher.py"
The images should be in "Images" folder
The readme files should be as "README.md"
README needs more elaboration.

Kindly do these changes. @photon149

@photon149
Copy link
Contributor Author

Done with the mentioned changes , can you recheck once.

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, congrats on your first PR. Yayy. It's approved. Well done. Amazing start. Get going. Welcome to the repo officially.✨🎉👏@photon149

@prathimacode-hub prathimacode-hub added the 🟩 Level1 This issue will be considered as level 1 issue for DevIncept 21.Points will be 10 label Jul 13, 2021
@prathimacode-hub prathimacode-hub merged commit 45c9586 into prathimacode-hub:main Jul 13, 2021
@welcome
Copy link

welcome bot commented Jul 13, 2021

Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DCP21 This issue will be considered for DCP21 🟩 Level1 This issue will be considered as level 1 issue for DevIncept 21.Points will be 10

2 participants