-
- Notifications
You must be signed in to change notification settings - Fork 40
Caesar_Cipher #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caesar_Cipher #44
Conversation
prathimacode-hub left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow the project structure given. It's not in right format. @photon149
| Please Review once. I have made some changes. |
prathimacode-hub left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I said you to follow the project structure as well.
Changes to be done:
The project folder should be titled as "Caesar Cipher"
The project file should be as "caesar_cipher.py"
The images should be in "Images" folder
The readme files should be as "README.md"
README needs more elaboration.
Kindly do these changes. @photon149
| Done with the mentioned changes , can you recheck once. |
prathimacode-hub left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, congrats on your first PR. Yayy. It's approved. Well done. Amazing start. Get going. Welcome to the repo officially.✨🎉👏@photon149
| Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️ |
Info about the related issue
DevIncept Participant
Contributor
Closes: #41 number that will be closed through this PR
Describe the changes you've made
The aim was to Caesar_Cipher problem. The code is running and is working perfectly.
Type of change
What sort of change have you made:
How Has This Been Tested?
Manually Run and Tested
Describe how have you verified the changes made
Checklist: