Skip to content

Conversation

@dhruv-varshney
Copy link
Contributor

@dhruv-varshney dhruv-varshney commented Jul 12, 2021

Related Issue
Add Sudoku Solver

  • DevIncept Participant

  • Contributor

Closes: #18

Describe the changes you've made

  • I have added Sudoku Solver using Backtracking

Type of change
What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Code style update (formatting, local variables)

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

  • This change requires a documentation update

How Has This Been Tested?
Describe how have you verified the changes made
I ran the program in my ubuntu operating system and ide is the text editor of ubuntu

Checklist:

  • My code follows the guidelines of this project.

  • I have performed a self-review of my own code.

  • I have commented on my code, particularly wherever it was hard to understand.

  • I have made corresponding changes to the documentation.

  • My changes generate no new warnings.

@welcome
Copy link

welcome bot commented Jul 12, 2021

Hello there! 👋 Welcome to the project! 💖
Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄

Feel free to get in touch with me through social media handles. Hope to see you there!😄

@ankitapuri ankitapuri added DCP21 This issue will be considered for DCP21 and removed DCP21 This issue will be considered for DCP21 labels Jul 12, 2021
@ankitapuri
Copy link

Related Issue
Add Binary Search.

DevIncept Participant

Contributor

Closes: #18

Describe the changes you've made

  • I have added Sudoku Solver using Backtracking

Type of change
What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?
Describe how have you verified the changes made
I ran the program in my ubuntu operating system and ide is the text editor of ubuntu

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added test cases that prove my fix is effective or that my feature works.

Just tick mark the boxes which suits your pull request in order to follow the template and so that we can review accordingly

@dhruv-varshney
Copy link
Contributor Author

Related Issue
Add Binary Search.
DevIncept Participant
Contributor
Closes: #18
Describe the changes you've made

  • I have added Sudoku Solver using Backtracking

Type of change
What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?
Describe how have you verified the changes made
I ran the program in my ubuntu operating system and ide is the text editor of ubuntu
Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added test cases that prove my fix is effective or that my feature works.

Just tick mark the boxes which suits your pull request in order to follow the template and so that we can review accordingly

now see I did some changes. I guess what all I ticked suits my pull request.

@ankitapuri ankitapuri added the DCP21 This issue will be considered for DCP21 label Jul 12, 2021
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work done. PR approved. Very well done. It was a wonderful choice of the script. 👏🤩@dhruv-varshney

@prathimacode-hub prathimacode-hub added the 🟨 Level2 This issue will be considered as level 2 issue for DevIncept 21.Points will be 15 label Jul 12, 2021
@prathimacode-hub prathimacode-hub merged commit 43b9234 into prathimacode-hub:main Jul 12, 2021
@welcome
Copy link

welcome bot commented Jul 12, 2021

Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️

@dhruv-varshney
Copy link
Contributor Author

Amazing work done. PR approved. Very well done. It was a wonderful choice of the script. 👏🤩@dhruv-varshney

Thank you @prathimacode-hub

@prathimacode-hub
Copy link
Owner

Kindly fill the form with your PR link. You have 1 PR merged in this project. Your response hasn't turned up yet. Form is available in slack project channel. @dhruv-varshney

@dhruv-varshney
Copy link
Contributor Author

dhruv-varshney commented Jul 18, 2021

ok ma'am , i will do it now only . Thanks for telling @prathimacode-hub

@dhruv-varshney
Copy link
Contributor Author

Hello @prathimacode-hub . I filled so many forms that are there in the slack channel but i can not able to get the link of the form where i have to fill the PR link. If possible Kindly send me the link here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DCP21 This issue will be considered for DCP21 🟨 Level2 This issue will be considered as level 2 issue for DevIncept 21.Points will be 15

3 participants