range.sql: drop redundant check for existing tables #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The check is always false as v_child_relname is schema-qualified while the comparison is to a plain table name. The entire check can be removed instead of fixing it as a few lines above we have a loop which comes up with a unique name.
| Yes, you are right. Actually the child relname check was moved into the loop above. I've just forget to remove it : ) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The check is always false as v_child_relname is schema-qualified while the
comparison is to a plain table name. The entire check can be removed
instead of fixing it as a few lines above we have a loop which comes up with
a unique name.