Skip to content

Selection.tsx Recurses Infinitely #330 #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Selection.tsx Recurses Infinitely #330 #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions src/Selection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,42 @@ export type SelectApi = Omit<ThreeElements['group'], 'ref'> & {
}

export const selectionContext = /* @__PURE__ */ createContext<Api | null>(null)
export const selectContext = /* @__PURE__ */ createContext<Api | null>(null)

export function Selection({ children, enabled = true }: { enabled?: boolean; children: React.ReactNode }) {
export function Selection(
{ children, enabled = true }: { enabled?: boolean; children: React.ReactNode }
) {
const [selected, select] = useState<THREE.Object3D[]>([])
const value = useMemo(() => ({ selected, select, enabled }), [selected, select, enabled])
return <selectionContext.Provider value={value}>{children}</selectionContext.Provider>
const selectApiRef = useRef({ selected, select, enabled })
const selectApi = selectApiRef.current

//non-reactive api for selectContext
selectApi.selected = selected
selectApi.select = select
selectApi.enabled = enabled

const selectionApi = useMemo(() => ({ selected, select, enabled }), [selected, select, enabled])

return (
<selectContext.Provider value={selectApiRef.current}>
<selectionContext.Provider value={selectionApi}>
{children}
</selectionContext.Provider>
</selectContext.Provider>
)
}

export function Select({ enabled = false, children, ...props }: SelectApi) {
const group = useRef<THREE.Group>(null!)
const api = useContext(selectionContext)
const api = useContext(selectContext)
useEffect(() => {
if (api && enabled) {
let changed = false
const current: THREE.Object3D[] = []
group.current.traverse((o) => {
o.type === 'Mesh' && current.push(o)
if (o.type === 'Mesh') {
current.push(o)
}
if (api.selected.indexOf(o) === -1) changed = true
})
if (changed) {
Expand All @@ -37,10 +57,10 @@ export function Select({ enabled = false, children, ...props }: SelectApi) {
}
}
}
}, [enabled, children, api])
}, [enabled, children, api]);
return (
<group ref={group} {...props}>
{children}
</group>
)
}
}