Skip to content

Allow null in mysqli*real_connect #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Allow null in mysqli*real_connect #2508

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6228cad
Allow null in mysqli_real_connect
staabm Jul 4, 2023
d9b8e43
added test
staabm Jul 4, 2023
b89dde1
better test
staabm Jul 4, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
better test
  • Loading branch information
@staabm
staabm committed Jul 4, 2023
commit b89dde162bea2cdbe5cbce0f5fd2b9e622b82cde
16 changes: 14 additions & 2 deletions tests/PHPStan/Rules/Functions/data/bug-2508.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

namespace Bug2508;

function connect(\mysqli $m): void
function connect(\mysqli $mysqli): void
{
mysqli_real_connect(
$m,
$mysqli,
null,
null,
null,
Expand All @@ -14,5 +14,17 @@ function connect(\mysqli $m): void
null,
\MYSQLI_CLIENT_SSL
);
}

function connectOop(\mysqli $mysqli): void
{
$mysqli->real_connect(
null,
null,
null,
null,
null,
null,
\MYSQLI_CLIENT_SSL
);
}