Attempt unloading Xdebug before showing warnings #2299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The Xdebug warning was being shown even when XdebugHandler would avoid the slow down by unloading the extension. This avoids showing the warning for users who have not disabled XdebugHandler via env or other means.
| Makes sense, thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The Xdebug warning was being shown even when XdebugHandler would avoid the slow down by unloading the extension. This avoids showing the warning for users who have not disabled XdebugHandler via env or other means.
This also has the benefit of making the second message less misleading as it is now only sown when users have a setup that is currently causing a needless slowdown of performance.