Add section on enumerations. #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
25 tasks
samdark reviewed May 3, 2022
mabar reviewed May 19, 2022
roxblnfk reviewed Jun 23, 2022
Co-authored-by: Aleksei Gagarin <roxblnfk@ya.ru>
samdark reviewed Jul 17, 2022
Member
| Changed CamelCase → PascalCase and resolved conflicts. |
samdark approved these changes Jul 17, 2022
KorvinSzanto approved these changes Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It occurs to me that there is no mention of constant capitalization anywhere else, but IMO constants in enums really should use CamelCase for consistency. (Frankly they should elsewhere, and I do use them that way elsewhere.) I don't know if we want to also mention constants more broadly.