Add a section on trailing commas #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
samdark approved these changes Jun 2, 2022
This was referenced Jun 2, 2022
TimWolla reviewed Jun 13, 2022
Contributor
TimWolla left a comment
TimWolla left a comment There was a problem hiding this comment.
The multi-line examples in sections "4.5 Method and Function Arguments" and "7. Closures" should likely also be updated to add the trailing comma.
Collaborator Author
| Yes, once we're comfortable with this change policy-wise I will update the PR to cover the rest of the document. I'm holding off on that until approval to minimize diff conflicts. @KorvinSzanto We need an internal decision/acceptance process. :-) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is consistent with what I have most often seen in the wild. It also makes for the easiest diffs.