Skip to content

Spec section 4: static methods should be called statically #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2025
Merged

Spec section 4: static methods should be called statically #123

merged 1 commit into from
Sep 10, 2025

Conversation

@DanielEScherzer
Copy link
Contributor

@DanielEScherzer DanielEScherzer commented Sep 10, 2025

Technically they work fine when called non-statically, but doing so is generally discouraged
@DanielEScherzer
Spec section 4: static methods should be called statically
d26a46a 
Technically they work fine when called non-statically, but doing so is generally discouraged
@DanielEScherzer DanielEScherzer mentioned this pull request Sep 10, 2025
Merged
KorvinSzanto
KorvinSzanto approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@KorvinSzanto KorvinSzanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this method is being called on an instance, either variant works fine and is perfectly allowed. That said, we already demonstrate ->someMethod() so we'd be better off using the paamneku.
@Crell Crell merged commit 2d833d8 into php-fig:master Sep 10, 2025
@Crell
Copy link
Collaborator

Crell commented Sep 10, 2025

Thanks, @DanielEScherzer!
@DanielEScherzer DanielEScherzer deleted the patch-2 branch September 11, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@DanielEScherzer @Crell @samdark @KorvinSzanto