Rename ServerDomain -> RPID #641
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
abergs force-pushed the rename-serverdomain-rpid branch from f19efe3 to 0d4d1ce Compare 
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #641 +/- ## ======================================= Coverage 78.37% 78.37% ======================================= Files 98 98 Lines 2539 2539 Branches 422 422 ======================================= Hits 1990 1990 Misses 439 439 Partials 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR renames the configuration properties ServerDomain and ServerName to the more spec aligned RPID and RPName.
This library aims to be close to the spec in naming, and having these two fields be anything different is just confusing.