Skip to content

refactor: upgrade React DND to v16 #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
damianstasik wants to merge 1 commit into
base: alpha
Choose a base branch
from
Draft

refactor: upgrade React DND to v16 #2278

damianstasik wants to merge 1 commit into from

Conversation

@damianstasik
Copy link
Contributor

@damianstasik damianstasik commented Sep 25, 2022 •
edited
Loading

New Pull Request Checklist

Issue Description

I upgraded React DnD to latest version which required a few changes due to breaking changes introduced in react-dnd@11+.

  1. Removed decorators required refactoring some code to hooks.
  2. Named export
  3. Hooks now need to return a function that returns a configuration.
  4. Item type should now be provided directly in configuration, not nested in item.

Note: this PR requires React 17 in order to work.

Related issue: #1950

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)
@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 25, 2022 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!
@damianstasik damianstasik mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@damianstasik