Parse error codes from unity using TryParse, to prevent exceptions. #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Parse/Internal/HttpClient.Unity.cs Outdated
Contributor
There was a problem hiding this comment.
Hmm. At this point www will return an error and we should return one, otherwise we'll break ParseCommandRunner https://github.com/ParsePlatform/Parse-SDK-dotNET/blob/master/Parse/Internal/Command/ParseCommandRunner.cs#L43. 201 isn't really an error.
I always wonder why they can't parse the string. Maybe the string doesn't contain number at all, which means it's a client error. By default we should return 400 https://github.com/hungrylabs/hungry/blob/gogo.push-xamarin-ios/windows/Parse/Parse/PlatformHooks.Unity.cs#L678
Contributor Author
There was a problem hiding this comment.
Good point. My mistake, will update.
I'm actually pretty sure 'error' is a string like 'network unavailable', but I'm not 100% sure.
When unity has no network, it returns a string such as 'no network', which causes `Int32.Parse` to throw an exception. Fixes #20.
richardjrossiii force-pushed the richardross.unity.httpclient.error branch from 7c3ac1a to 3ad2304 Compare 
Contributor
| LGTM ship! |
richardjrossiii added a commit that referenced this pull request Oct 1, 2015
…t.error Parse error codes from unity using TryParse, to prevent exceptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When unity has no network, it returns an empty string for 'error', which causes
Int32.Parseto throw an exception.Fixes #20.
cc @hallucinogen @grantland