Properly unwrap tasks returned during signup. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Because this task wasn't properly unwrapped, 'OnSuccess' was always being invoked, as the task was techincally successful. This caused a regression, where we always would set the current user to be this object, even if an error occured during save. Fixes #10.
Contributor
| LGTM! |
richardjrossiii added a commit that referenced this pull request Sep 28, 2015
Properly unwrap tasks returned during signup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Because this task wasn't properly unwrapped, 'OnSuccess' was always being invoked, as the task was techincally successful. This caused a regression, where we always would set the current user to be this object, even if an error occured during save.
Fixes #10.
cc @hallucinogen @grantland