Remove obj_with_exclusions #50878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

rhshadrach wants to merge 7 commits into pandas-dev:main from rhshadrach:remove_obj_with_exclusions

Member

rhshadrach commented Jan 19, 2023

closes CLN/DOC: _selected_obj vs _obj_with_exclusions #46944 (Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Built on #50846; just testing whether obj_with_exclusions is now the same as selected_obj with the exception of #50805

rhshadrach added 6 commits

January 18, 2023 17:29

BUG: groupby.describe on a frame with duplicate column names

0bdf009

cleanup

185e4f8

test fixup

d2b965f

Fix type-hint for _group_selection

932e3c8

Merge branch 'main' of https://github.com/pandas-dev/pandas into grou…

5139df8

…pby_select_obj_dup_cols

REF: Remove groupby._obj_with_exclusions

d188bdb

rhshadrach added Refactor Groupby labels

rhshadrach marked this pull request as draft

January 19, 2023 22:16

Member

jbrockmendel commented Jan 19, 2023

(Not having looked at the code) nice!

Fixup xfail

8dc0f93

rhshadrach mentioned this pull request

CLN/DOC: _selected_obj vs _obj_with_exclusions #46944

Open

Member

jbrockmendel commented Feb 7, 2023

Is this still viable?

Member Author

rhshadrach commented Feb 8, 2023

Nope - closing.

rhshadrach closed this

rhshadrach deleted the remove_obj_with_exclusions branch

February 8, 2023 03:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment