[GR-69861] [GR-69760] Add BytecodeFrame and GenerateBytecode#captureFramesForTrace, fix/improve continuation frame support. #12536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The default `countsTowardsStackTraceLimit` impl invokes `isInternal`, which used to force materialization of sources in the Bytecode DSL. To prevent this eager materialization, we overrode `countsTowardsStackTraceLimit` to `true` when the user did not implement it. This is incorrect: the user could override `isInternal`, but the `countsTowardsStackTraceLimit` override would ignore it. Since eager materialization no longer occurs, we can stop generating an override for this method.
…ent classes; code generation should not delegate to super method if they are abstract.
…ace configuration option Adds a new BytecodeFrame abstraction that captures the frame and location information. This abstraction should be preferred over BytecodeNode helpers since it ensures the correct location is used. Also adds a new GenerateBytecode#captureFramesForTrace configuration option that directs the interpreter to capture frames for interpreter use. Previously, the frame would sometimes be available depending on internal interpreter correctness requirements. Now, the frame is reliably available depending on the configuration option. Lanugages should use BytecodeFrame.get(element) to obtain the frame data from a TruffleStackTraceElement (element.getFrame() may still return a non-null value, but its use by languages is not supported).
oracle-contributor-agreement bot added the OCA Verified 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Best reviewed by commit.
This PR adds:
BytecodeFrameabstraction, which is the encouraged way to access frame data. It includes accessors for locals, local names, and arguments. IncludesBytecodeFrame.getNonVirtualFrame(...)methods to obtain a non-virtual frame when it is available.GenerateBytecode#captureFramesForTracefield. Previously, frames would be captured sometimes depending on internal interpreter correctness reasons. Now, frames will not be exposed to users unless they opt-in using this flag.BytecodeRootNode.get(FrameInstance|TruffleStackTraceElement)helper methods to obtain aBytecodeNodegiven a frame instance/stack trace element.Also fixes bugs with:
BytecodeNode#setLocalValuesandContinuationRootNodeImpl#findBytecodeIndexnot unwrapping continuation framesContinuationRootNodeImplnot delegating enough methodscountsTowardsStackTraceLimit