Low allocation OTLP metrics marshaler #6422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #6422 +/- ## ============================================ + Coverage 90.85% 91.26% +0.41% - Complexity 6028 6107 +79 ============================================ Files 651 667 +16 Lines 17729 18114 +385 Branches 1777 1792 +15 ============================================ + Hits 16107 16532 +425 + Misses 1105 1061 -44 - Partials 517 521 +4 ☔ View full report in Codecov by Sentry. |
This was referenced May 3, 2024
jack-berg reviewed May 6, 2024
...java/io/opentelemetry/exporter/internal/otlp/metrics/SummaryDataPointStatelessMarshaler.java Outdated Show resolved Hide resolved
...src/main/java/io/opentelemetry/exporter/internal/otlp/metrics/SummaryStatelessMarshaler.java Outdated Show resolved Hide resolved
| public int getBinarySerializedSize(SummaryData summary, MarshalerContext context) { | ||
| int size = 0; | ||
| size += | ||
| StatelessMarshalerUtil.sizeRepeatedMessageWithContext( |
There was a problem hiding this comment.
What's the didfference between the sizeRepeatedMessageWithContext overloads? One accepts a MarshalerContext.Key and another doesn't.
There was a problem hiding this comment.
The ones with key use forEach to traverse Collection or Map. Key is used to cache the Consumer that is passed to forEach. The ones without key use a counted loop.
...elemetry/exporter/internal/otlp/metrics/ExponentialHistogramDataPointStatelessMarshaler.java Show resolved Hide resolved
.../java/io/opentelemetry/exporter/internal/otlp/metrics/ResourceMetricsStatelessMarshaler.java Outdated Show resolved Hide resolved
...va/io/opentelemetry/exporter/internal/otlp/metrics/LowAllocationMetricsRequestMarshaler.java Outdated Show resolved Hide resolved
.../src/main/java/io/opentelemetry/exporter/internal/otlp/metrics/MetricStatelessMarshaler.java Outdated Show resolved Hide resolved
jack-berg approved these changes May 7, 2024
This was referenced May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Continuation of #6410