Skip to content

Conversation

@ActiveChooN
Copy link

📝 Description

Added exported model size attribute

  • Provide a clear summary of the changes and the issue that has been addressed.
  • 🛠️ Fixes # (issue number)

✨ Changes

Select what type of change your PR is:

  • 🚀 New feature (non-breaking change which adds functionality)
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔄 Refactor (non-breaking change which refactors the code base)
  • ⚡ Performance improvements
  • 🎨 Style changes (code style/formatting)
  • 🧪 Tests (adding/modifying tests)
  • 📚 Documentation update
  • 📦 Build system changes
  • 🚧 CI/CD configuration
  • 🔧 Chore (general maintenance)
  • 🔒 Security update
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
  • 🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

…ates Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Copilot AI review requested due to automatic review settings November 18, 2025 12:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an exported model size attribute to track the total size in bytes of exported model artifacts. The implementation computes the size after model export and stores it in the database.

Key changes:

  • Added a size field to the Model schema to store the total size in bytes of exported model artifacts
  • Implemented _compute_export_size method to calculate total size of files/directories in the export path
  • Created a database migration to add the size column to the models table

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
application/backend/src/pydantic_models/model.py Added size field to Model schema with validation
application/backend/src/db/schema.py Added size column to ModelDB table using BigInteger
application/backend/src/services/training_service.py Implemented _compute_export_size method and integrated size computation into training flow
application/backend/src/alembic/versions/7bbe7699b43a_add_model_size_column.py Database migration to add size column
application/backend/tests/unit/services/test_training_service.py Updated test to mock and verify size computation
application/backend/tests/unit/endpoints/test_models.py Added size field to fixture and verified in API response
application/backend/tests/unit/conftest.py Added size field to model fixture

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ActiveChooN ActiveChooN changed the title feat(geti-inpect): exported model size feat(geti-inspect): exported model size Nov 18, 2025
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
@ActiveChooN ActiveChooN changed the title feat(geti-inspect): exported model size feat(inspect): exported model size Nov 18, 2025
@ActiveChooN ActiveChooN marked this pull request as ready for review November 18, 2025 13:53
@ActiveChooN ActiveChooN requested a review from maxxgx as a code owner November 18, 2025 13:53
Copilot AI review requested due to automatic review settings November 18, 2025 13:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@maxxgx maxxgx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Looks good, thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that you are adding the schema migration script, but since we have not released any version yet, it does not make sense to have a migration at this stage. Rather, you can add the size column to the initial schema 7a213a27d666_initial_schema.py

Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
@ActiveChooN ActiveChooN merged commit 0b08527 into open-edge-platform:feature/geti-inspect Nov 19, 2025
18 checks passed
@ActiveChooN ActiveChooN deleted the exported-model-size branch November 19, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants