ENH: Add subok parameter to np.copy function (cf. #6509) #15685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Re-introduces changes originally proposed in numpy#6509 which was closed due to very long review period.
charris added 01 - Enhancement component: numpy.lib 56 - Needs Release Note. 
| Needs a release note. |
seberg removed the 56 - Needs Release Note. 
eric-wieser reviewed Mar 4, 2020
Incorporate rst formatting feedback
mattip reviewed Mar 4, 2020
mattip reviewed Mar 4, 2020
Added sentence to highlight difference bewteen np.copy and np.ndarray.copy method.
Update docstring "default" to be more explicit Co-Authored-By: Matti Picus <matti.picus@gmail.com>
| Okay, that should be everything - if the updated release note needs some re-wording let me know (or feel free to make the suggestion directly). |
stefanv approved these changes Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is largely a re-submission of the original change proposed in #6509. Discussion was hosted in multiple forums including #3474, the numpy mailing list circa 10-2015, and the 02-26-2020 NumPy Triage meeting.
This PR closes #3474 and #15570