updated 2fa related docs removing totp refs #1740
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
saquibkhan changed the title 
saquibkhan force-pushed the deprecate-totp-2fa branch from cb62174 to f3d46a7 Compare saquibkhan had a problem deploying to github-pages 
GitHub Actions Failure 
leobalter requested changes Oct 9, 2025
...t/getting-started/setting-up-your-npm-user-account/configuring-two-factor-authentication.mdx Outdated Show resolved Hide resolved
...t/getting-started/setting-up-your-npm-user-account/configuring-two-factor-authentication.mdx Outdated Show resolved Hide resolved
...t/getting-started/setting-up-your-npm-user-account/configuring-two-factor-authentication.mdx Outdated Show resolved Hide resolved
...t/getting-started/setting-up-your-npm-user-account/configuring-two-factor-authentication.mdx Outdated Show resolved Hide resolved
...ent/getting-started/setting-up-your-npm-user-account/recovering-your-2fa-enabled-account.mdx Outdated Show resolved Hide resolved
There was a problem hiding this comment.
note (no need to change in this PR): in a future it would be ideal to just remove this extra step as it's now an assertion rather than an option.
There was a problem hiding this comment.
you are correct ,now this 2fa method doesn't make any sense and we can take user directly to configure screen. i'll add a note could be a future task to also make respective change in the UI
Edit; Added a note here - https://github.com/github/npm/issues/14221#issuecomment-3387848940
leobalter requested changes Oct 9, 2025
static/getting-started/.DS_Store Outdated
There was a problem hiding this comment.
you may want to remove this file. You can have .DS_Store in your ignore settings.
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
saquibkhan had a problem deploying to github-pages GitHub Actions Failure 
| @leobalter thanks for the review comments, i think i addressed all your comments, requesting another round of review |
saquibkhan had a problem deploying to github-pages GitHub Actions Failure saquibkhan had a problem deploying to github-pages GitHub Actions Failure leobalter approved these changes Oct 13, 2025
owlstronaut approved these changes Oct 13, 2025
saquibkhan had a problem deploying to github-pages GitHub Actions Failure 
shmam added a commit that referenced this pull request Oct 13, 2025
changes from #1740 ## References <!-- Examples: Related to #0 Depends on #0 Blocked by #0 Fixes #0 Closes #0 -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
updated 2fa related docs removing totp refs
References