Skip to content

Conversation

jpg619
Copy link
Contributor

@jpg619 jpg619 commented Oct 8, 2025

File Changes (3 files modified):

  1. link.js - Enhanced Link component with configurable underline styling support
  2. src/components/contributors.js - Applied underline styling to contributor and commit links for better accessibility
  3. table-of-contents.js - Added underline styling to table of contents navigation links

Summary:

Enhanced the Link component to support optional underline styling through a showUnderline prop and applied underline styling to key navigation elements across the documentation site to improve link visibility and accessibility compliance.

Changes Overview:

  • Added showUnderline prop to Link component for configurable text decoration
  • Applied underlines to contributor profile links and commit date links
  • Enhanced table of contents with underlined navigation links
  • Maintained backward compatibility with existing link styling

Before

image image

After

image image
@jpg619 jpg619 marked this pull request as ready for review October 8, 2025 17:13
@jpg619 jpg619 requested review from a team and leobalter as code owners October 8, 2025 17:13
@jpg619 jpg619 requested review from Copilot and owlstronaut October 8, 2025 17:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enhanced the Link component to support optional underline styling through a showUnderline prop and applied underline styling to improve link visibility and accessibility across documentation components.

  • Added configurable underline styling to the Link component with backward compatibility
  • Applied underline styling to contributor and commit links in the page footer
  • Enhanced table of contents navigation with underlined links

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/components/link.js Added showUnderline prop and conditional underline styling logic
src/components/page-footer.js Applied underline styling to contributor profile and commit date links
src/components/table-of-contents.js Added underline styling to table of contents navigation links

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jpg619 jpg619 merged commit caa3cf4 into main Oct 8, 2025
9 checks passed
@jpg619 jpg619 deleted the jpg619/fix-accessibility-sev-4-2025 branch October 8, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants