test: refactor fs readdir buffer with test runner #55748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
sercanpaspal force-pushed the test-refactor-fs-readdir-buffer-with-test-runner branch from a0d780f to 684e6b9 Compare 
bengl added code-and-learn 
github-actions bot removed the request-ci 
Collaborator
sercanpaspal force-pushed the test-refactor-fs-readdir-buffer-with-test-runner branch 2 times, most recently from ab09006 to 843bb2d Compare 
Member
| Hey @sercanpaspal, js linting is failing.  |
sercanpaspal force-pushed the test-refactor-fs-readdir-buffer-with-test-runner branch from 843bb2d to 33c87c4 Compare 
Author
| Hi @pmarchini , thank you for your help & information. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #55748 +/- ## ========================================== - Coverage 88.40% 87.91% -0.49% ========================================== Files 654 654 Lines 187747 187747 Branches 36127 35820 -307 ========================================== - Hits 165972 165062 -910 - Misses 15009 15888 +879 - Partials 6766 6797 +31
|
jasnell approved these changes Nov 23, 2024
Collaborator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Refactor of
test/parallel/test-fs-readdir-buffer.jswith node test runner.