src: avoid X509_free in loops in crypto_x509.cc #44855
Merged
+7 −9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use X509Pointer objects for automatic memory management instead.
tniessen added tls 
Collaborator
| Review requested:
|
github-actions bot removed the request-ci 
RaisinTen approved these changes Oct 2, 2022
jasnell approved these changes Oct 2, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
16 tasks
Collaborator
tniessen added author ready 
nodejs-github-bot removed the commit-queue Collaborator
| Landed in e84e2e6 |
This was referenced Oct 5, 2022
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
Use X509Pointer objects for automatic memory management instead. PR-URL: #44855 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use
X509Pointerobjects for automatic memory management instead.