[v18.x backport] lib: reset RegExp statics before running user code

[aduh95]

Fixes: #43740

PR-URL: #43741
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com

[nodejs-github-bot]

Review requested:

• @nodejs/modules

[aduh95]

It looks like the lint failure was introduced by 5cb5c65.

[danielleadams]

@aduh95 I had to rest v18.x-staging, sorry but this will need a rebase

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46185/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46422/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46428/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46432/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46444/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46455/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46461/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46462/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46487/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46619/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46620/

[RafaelGSS]

@aduh95 Is it ready to land? I'm about to including it to the v18 proposal

[aduh95]

It is ready to land, thanks for taking care of this :)

[RafaelGSS]

It is ready to land, thanks for taking care of this :)

Can you amend the Backport-PR-URL metadata to your commit message?

[aduh95]

It is ready to land, thanks for taking care of this :)

Can you amend the Backport-PR-URL metadata to your commit message?

Sure I can, but I find it surprising as of all the backport PRs I've opened, I've never touched the commit message, and it was taken care of upon landing – also if I push another commit, that means we'd probably need another CI run, which I'd rather avoid. Are you sure that's not something that ncu takes care of?

[RafaelGSS]

@nodejs/releasers Do ncu handle it by default? I'm just asking because following the https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md#how-to-submit-a-backport-pull-request step 9.v says:

Amend the commit message and include a Backport-PR-URL: metadata and re-push the change to your fork.

I think I can include that metadata while merging using git node land X, but I'm not quite sure if that's the correct workflow.

[RafaelGSS]

Landed in 687ffcc

[RafaelGSS]

@aduh95 just realized that I can do it manually using ncu. Sorry for the inconvenience.

[richardlau]

@nodejs/releasers Do ncu handle it by default? I'm just asking because following the https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md#how-to-submit-a-backport-pull-request step 9.v says:

Amend the commit message and include a Backport-PR-URL: metadata and re-push the change to your fork.

I think I can include that metadata while merging using git node land X, but I'm not quite sure if that's the correct workflow.

Use --backport with git node land (nodejs/node-core-utils#383).