Pull latest commits from node core #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PR-URL: nodejs/node#43989 Refs: nodejs/node#43554 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> (cherry picked from commit 7a18ee8315ecc8ad1a1316ff1c951694f8e8f7a4)
| probably these should be added as well - both waiting for 48 hours to pass |
PR-URL: nodejs/node#43997 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> (cherry picked from commit f0639eb8bad739b27b7cdefef4fac8e48c889f16)
PR-URL: nodejs/node#43976 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> (cherry picked from commit 60da0a1b364efdd84870269d23b39faa12fb46d8)
PR-URL: nodejs/node#43977 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> (cherry picked from commit 26e27424ad91c60a44d3d4c58b62a39b555ba75d)
aduh95 force-pushed the pull-latest-commits-from-node-core branch from 63fcecf to 4071052 Compare PR-URL: nodejs/node#43998 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> (cherry picked from commit a3e110820ff98702e1761831e7beaf0f5f1f75e7)
MoLow reviewed Jul 29, 2022
| return | ||
| } | ||
| let stdout = '' | ||
| const child = spawn(process.execPath, ['--test', file]) |
There was a problem hiding this comment.
How does this pass in node 16/14?
There was a problem hiding this comment.
node-core-test/test/common/index.js
Line 9 in 4071052
MoLow approved these changes Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Opening as draft as I'd like to pull nodejs/node#43997 as well before releasing a new version.