Skip to content

Conversation

uyw4687
Copy link

@uyw4687 uyw4687 commented Oct 29, 2020

No description provided.

@nayuki
Copy link
Owner

nayuki commented Nov 12, 2020

Rejected for the following reasons:

  • Timing and compression ratio are not functionalities I want in the program. You can achieve timing easily with the Unix time command.
  • The .gitignore file doesn't reflect everybody's preferences. If you look at all my projects, I have almost zero gitignore files. This is not an accident; this is deliberate.
  • The format of your imports doesn't follow my format.
  • The change in the command-line arguments is not in improvement in my opinion. Stating the input and output files explicitly is clearer in this situation.
  • We don't use the ancient % string formatting operator anymore. I use f-strings (Python 3.6+).
  • Too many blank lines were added.
  • Poorly formatted whitespace in code, such as: print("text text"% (t2-t1) ), which should be print("text text" % (t2 - t1))
@nayuki nayuki closed this Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants