Skip to content

Conversation

@nikithauc
Copy link
Contributor

Fixes #470

Copy link
Contributor

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sendUsersMail image and link is a bit off. Should probably be in a section about typings.

Also, there are duplicate links to samples and tutorials at the bottom of the document. Perhaps that is a good thing, it is nice to find the links in the TOC.

@nikithauc
Copy link
Contributor Author

The sendUsersMail image and link is a bit off. Should probably be in a section about typings.

Also, there are duplicate links to samples and tutorials at the bottom of the document. Perhaps that is a good thing, it is nice to find the links in the TOC.

@MIchaelMainer can you explain what should be the correction be for the sendUsersMail image and link?

The duplicate links in the TOC and the samples sections are intentional.

@MIchaelMainer
Copy link
Contributor

@nikithauc The sendUsersMail image and link occur in the same section as that TOC/Navigation section. There should a section and description that describe what the image is and why the customer should follow it.

Perhaps something like:

TypeScript

This client library is supported with typings that represent the objects in Microsoft Graph. We provide typing support for the v1.0 and beta models.

TypeScript demo

@nikithauc
Copy link
Contributor Author

@nikithauc The sendUsersMail image and link occur in the same section as that TOC/Navigation section. There should a section and description that describe what the image is and why the customer should follow it.

Perhaps something like:

TypeScript

This client library is supported with typings that represent the objects in Microsoft Graph. We provide typing support for the v1.0 and beta models.

TypeScript demo
Done!

@nikithauc nikithauc merged commit c2fe947 into dev Jun 18, 2021
@nikithauc nikithauc deleted the documentation/sample-links branch June 18, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants