Bug fixes: #152, #153, #156 #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
muthurathinam requested review from MIchaelMainer, NakulSabharwal, darrelmiller and deepak2016 
darrelmiller approved these changes Apr 15, 2019
Contributor
| @deepak2016 Can you review and approve this PR as it has important bug fixes in it. |
deepak2016 approved these changes Apr 15, 2019
| | ||
| <body style="background: #f3f3f3;"> | ||
| <div class="fileUploadParent"> | ||
| <!-- <div class="fileUploadParent"> |
There was a problem hiding this comment.
why keeping commented code in the repo?
| | ||
| let displayName = await request.getDisplayName(); | ||
| ui.setDisplayName(displayName); | ||
| // let displayName = await request.getDisplayName(); |
There was a problem hiding this comment.
minor: why keeping commented code, instead of deleting?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three issues.
Test plan
run
npm testto validate the newly added test cases.Closing issues
Types of changes
Checklist