Skip to content

Conversation

@Andarist
Copy link
Contributor

@Andarist Andarist commented Nov 5, 2025

⚠️ The current implementation here could use some further work but before putting more work into it, I'd like to get some results from the extended tests and some initial feedback about the idea

The idea behind this PR is rather simple. Context-sensitive nodes are skipped by the first inference pass but that doesn't always mean they can't contain valid inference sources. Furthermore, using the constraints as inferred types after the first pass leads to signature applicability errors and thus skipping the second inference pass altogether (the one that starts including context-sensitive nodes).

So, whenever something potentially could be inferred into a type parameter from a context-sensitive node we can temporarily infer a wildcard to satisfy the signature applicability check with a more permissive candidate instantiation. Then the compiler can get to the second inference pass and potentially infer useful and concrete candidates.

This fixes a class of issues around inference in the presence of context-sensitive expressions when parts of the signature want to "process" the inferred type with conditional types and whatnot. Like here:

declare function TestConfig_2< const TConfig extends { a?: any; b?: (arg: number) => unknown; c?: any }, >( config: TConfig, test: keyof Omit<TConfig, "a" | "b"> extends never ? true : false, ): void; TestConfig_2( { a: "hello", b: (arg) => { return "123"; }, }, true, // currently an error but fixed with this PR );

fixes #62204
fixes #55489
fixes #55124
fixes #54438
and fixes some of the issues reported in #47599

@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Nov 5, 2025
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 5, 2025
@Andarist Andarist changed the title Infer wildcard from contains any function type Improve inference for signatures depending on types inferred from context-sensitive expressions Nov 5, 2025
@jakebailey
Copy link
Member

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 5, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started 👀 Results
run dt ✅ Started 👀 Results
perf test this faster ✅ Started 👀 Results
@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: carbon-components-react
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/carbon-components-react/carbon-components-react-tests.tsx 586:22 error TypeScript@local compile error: Parameter 'evt' implicitly has an 'any' type @definitelytyped/expect ✖ 1 problem (1 error, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: d3-selection
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/d3-selection/d3-selection-tests.ts 919:31 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 919:34 error TypeScript@local compile error: Parameter 'i' implicitly has an 'any' type @definitelytyped/expect 919:37 error TypeScript@local compile error: Parameter 'g' implicitly has an 'any' type @definitelytyped/expect 928:12 error TypeScript@local compile error: 'this' implicitly has type 'any' because it does not have a type annotation @definitelytyped/expect 940:12 error TypeScript@local compile error: 'this' implicitly has type 'any' because it does not have a type annotation @definitelytyped/expect 1231:21 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect 1231:56 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 1242:30 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect 1242:67 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 1259:5 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect 1259:40 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 1277:5 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect 1277:42 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 1324:10 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect 1354:9 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect 1354:9 error TypeScript@local compile error: No overload matches this call. Overload 1 of 2, '(enter: "symbol" | "animate" | "animateMotion" | "animateTransform" | "circle" | "clipPath" | "defs" | "desc" | "ellipse" | "feBlend" | "feColorMatrix" | "feComponentTransfer" | ... 47 more ... | keyof HTMLElementTagNameMap, update?: ((elem: Selection<...>) => Selection<...> | ... 1 more ... | undefined) | undefined, exit?: ((elem: Selection<...>) => void) | undefined): Selection<...>', gave the following error. Argument of type '(enter: any) => TransitionLike<BaseType, unknown>' is not assignable to parameter of type '"symbol" | "animate" | "animateMotion" | "animateTransform" | "circle" | "clipPath" | "defs" | "desc" | "ellipse" | "feBlend" | "feColorMatrix" | "feComponentTransfer" | "feComposite" | ... 46 more ... | keyof HTMLElementTagNameMap'. Overload 2 of 2, '(enter: string | ((elem: Selection<EnterElement, number, HTMLElement, unknown>) => TransitionLike<HTMLElement, number> | Selection<...>), update?: ((elem: Selection<...>) => Selection<...> | ... 1 more ... | undefined) | undefined, exit?: ((elem: Selection<...>) => void) | undefined): Selection<...>', gave the following error. Argument of type '(enter: any) => TransitionLike<BaseType, unknown>' is not assignable to parameter of type 'string | ((elem: Selection<EnterElement, number, HTMLElement, unknown>) => TransitionLike<HTMLElement, number> | Selection<...>)'. Type '(enter: any) => TransitionLike<BaseType, unknown>' is not assignable to type '(elem: Selection<EnterElement, number, HTMLElement, unknown>) => TransitionLike<HTMLElement, number> | Selection<...>'. Type 'TransitionLike<BaseType, unknown>' is not assignable to type 'TransitionLike<HTMLElement, number> | Selection<BaseType, number, HTMLElement, unknown>'. Type 'TransitionLike<BaseType, unknown>' is not assignable to type 'TransitionLike<HTMLElement, number>'. Type 'BaseType' is not assignable to type 'HTMLElement'. Type 'null' is not assignable to type 'HTMLElement' @definitelytyped/expect 1354:79 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect ✖ 17 problems (17 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: d3-selection/v2
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/d3-selection/v2/d3-selection-tests.ts 917:31 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 917:34 error TypeScript@local compile error: Parameter 'i' implicitly has an 'any' type @definitelytyped/expect 917:37 error TypeScript@local compile error: Parameter 'g' implicitly has an 'any' type @definitelytyped/expect 926:12 error TypeScript@local compile error: 'this' implicitly has type 'any' because it does not have a type annotation @definitelytyped/expect 938:12 error TypeScript@local compile error: 'this' implicitly has type 'any' because it does not have a type annotation @definitelytyped/expect 1226:21 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect 1226:56 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 1237:30 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect 1237:67 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 1254:5 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect 1254:40 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 1272:5 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect 1272:42 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 1319:10 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect ✖ 14 problems (14 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: d3-selection/v1
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/d3-selection/v1/d3-selection-tests.ts 903:31 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 903:34 error TypeScript@local compile error: Parameter 'i' implicitly has an 'any' type @definitelytyped/expect 903:37 error TypeScript@local compile error: Parameter 'g' implicitly has an 'any' type @definitelytyped/expect 912:12 error TypeScript@local compile error: 'this' implicitly has type 'any' because it does not have a type annotation @definitelytyped/expect 924:12 error TypeScript@local compile error: 'this' implicitly has type 'any' because it does not have a type annotation @definitelytyped/expect 1281:21 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect 1281:56 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 1292:30 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect 1292:67 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 1309:5 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect 1309:40 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 1327:5 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect 1327:42 error TypeScript@local compile error: Parameter 'd' implicitly has an 'any' type @definitelytyped/expect 1374:10 error TypeScript@local compile error: Parameter 'enter' implicitly has an 'any' type @definitelytyped/expect ✖ 14 problems (14 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: react/v18
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/react/v18/test/tsx.tsx 321:19 error TypeScript@local compile error: Expression produces a union type that is too complex to represent @definitelytyped/expect ✖ 1 problem (1 error, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: react
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/react/test/tsx.tsx 303:19 error TypeScript@local compile error: Expression produces a union type that is too complex to represent @definitelytyped/expect ✖ 1 problem (1 error, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: jquery-jcrop
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/jquery-jcrop/jquery-jcrop-tests.ts 1:9 error TypeScript@local compile error: Parameter '$' implicitly has an 'any' type @definitelytyped/expect 10:9 error TypeScript@local compile error: Parameter '$' implicitly has an 'any' type @definitelytyped/expect 17:9 error TypeScript@local compile error: Parameter '$' implicitly has an 'any' type @definitelytyped/expect 32:9 error TypeScript@local compile error: Parameter '$' implicitly has an 'any' type @definitelytyped/expect 38:21 error TypeScript@local compile error: 'this' implicitly has type 'any' because it does not have a type annotation @definitelytyped/expect 41:29 error TypeScript@local compile error: Parameter 'e' implicitly has an 'any' type @definitelytyped/expect 46:28 error TypeScript@local compile error: Parameter 'e' implicitly has an 'any' type @definitelytyped/expect ✖ 7 problems (7 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: layui
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/layui/test/table.test.ts 309:34 error TypeScript@local compile error: Parameter 'obj' implicitly has an 'any' type @definitelytyped/expect 312:34 error TypeScript@local compile error: Parameter 'obj' implicitly has an 'any' type @definitelytyped/expect 315:38 error TypeScript@local compile error: Parameter 'obj' implicitly has an 'any' type @definitelytyped/expect /mnt/vss/_work/1/DefinitelyTyped/types/layui/test/tabs.test.ts 48:33 error TypeScript@local compile error: Parameter 'data' implicitly has an 'any' type @definitelytyped/expect ✖ 4 problems (4 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: oojs
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/oojs/oojs-tests.ts 103:5 error TypeScript@local compile error: Excessive stack depth comparing types 'LeavesOf<T, ?>' and 'LeavesOf<T, ?>' @definitelytyped/expect 103:5 error TypeScript@local compile error: Type instantiation is excessively deep and possibly infinite @definitelytyped/expect 108:5 error TypeScript@local compile error: Excessive stack depth comparing types 'NodesOf<T, ?>' and 'NodesOf<T, ?>' @definitelytyped/expect 108:5 error TypeScript@local compile error: Type instantiation is excessively deep and possibly infinite @definitelytyped/expect ✖ 4 problems (4 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: pg
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/pg/pg-tests.ts 55:48 error TypeScript@local compile error: Parameter 'err' implicitly has an 'any' type @definitelytyped/expect 55:53 error TypeScript@local compile error: Parameter 'result' implicitly has an 'any' type @definitelytyped/expect 74:31 error TypeScript@local compile error: Parameter 'err' implicitly has an 'any' type @definitelytyped/expect 74:36 error TypeScript@local compile error: Parameter 'res' implicitly has an 'any' type @definitelytyped/expect ✖ 4 problems (4 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: yaireo__tagify
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/yaireo__tagify/test/index.ts 1107:23 error TypeScript@local compile error: Parameter 'data' implicitly has an 'any' type @definitelytyped/expect ✖ 1 problem (1 error, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: jquery
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/jquery/jquery-tests.ts 139:20 error TypeScript@local compile error: Parameter '$' implicitly has an 'any' type @definitelytyped/expect 143:13 error TypeScript@local expected type to be: JQueryStatic got: any @definitelytyped/expect /mnt/vss/_work/1/DefinitelyTyped/types/jquery/test/example-tests.ts 3331:25 error TypeScript@local compile error: Parameter '$' implicitly has an 'any' type @definitelytyped/expect /mnt/vss/_work/1/DefinitelyTyped/types/jquery/test/longdesc-tests.ts 2166:22 error TypeScript@local compile error: Parameter '$' implicitly has an 'any' type @definitelytyped/expect ✖ 4 problems (4 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: meteor-mdg-validated-method
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/meteor-mdg-validated-method/meteor-mdg-validated-method-tests.ts 149:21 error TypeScript@local compile error: Argument of type '{ name: "methodWithFaultySchemaMixin"; mixins: (() => void)[]; run(): string; }' is not assignable to parameter of type 'ValidatedMethodOptionsWithMixins<"methodWithFaultySchemaMixin", any> & ThisType<ValidatedMethodThisBase & { name: "methodWithFaultySchemaMixin"; }>'. Property 'validate' is missing in type '{ name: "methodWithFaultySchemaMixin"; mixins: (() => void)[]; run(): string; }' but required in type 'ValidatedMethodOptionsWithMixins<"methodWithFaultySchemaMixin", any>' @definitelytyped/expect 151:5 error TypeScript@local compile error: Unused '@ts-expect-error' directive @definitelytyped/expect 159:21 error TypeScript@local compile error: Argument of type '{ name: "methodWithFaultySchemaMixin"; mixins: ((args: any) => any)[]; run(): string; }' is not assignable to parameter of type 'ValidatedMethodOptionsWithMixins<"methodWithFaultySchemaMixin", any> & ThisType<ValidatedMethodThisBase & { name: "methodWithFaultySchemaMixin"; }>'. Property 'validate' is missing in type '{ name: "methodWithFaultySchemaMixin"; mixins: ((args: any) => any)[]; run(): string; }' but required in type 'ValidatedMethodOptionsWithMixins<"methodWithFaultySchemaMixin", any>' @definitelytyped/expect ✖ 3 problems (3 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: lodash
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/lodash/lodash-tests.ts 2885:18 error TypeScript@local compile error: Parameter 'value' implicitly has an 'any' type @definitelytyped/expect 2885:25 error TypeScript@local compile error: Parameter 'index' implicitly has an 'any' type @definitelytyped/expect 2885:32 error TypeScript@local compile error: Parameter 'collection' implicitly has an 'any' type @definitelytyped/expect 2886:9 error TypeScript@local expected type to be: AbcObject got: any @definitelytyped/expect 2887:9 error TypeScript@local expected type to be: number got: any @definitelytyped/expect 2888:9 error TypeScript@local expected type to be: ArrayLike<AbcObject> || List<AbcObject> got: any @definitelytyped/expect 2893:24 error TypeScript@local compile error: Parameter 'value' implicitly has an 'any' type @definitelytyped/expect 2893:31 error TypeScript@local compile error: Parameter 'key' implicitly has an 'any' type @definitelytyped/expect 2893:36 error TypeScript@local compile error: Parameter 'collection' implicitly has an 'any' type @definitelytyped/expect 2894:9 error TypeScript@local expected type to be: AbcObject got: any @definitelytyped/expect 2895:9 error TypeScript@local expected type to be: string got: any @definitelytyped/expect 2896:9 error TypeScript@local expected type to be: Dictionary<AbcObject> got: any @definitelytyped/expect 2901:31 error TypeScript@local compile error: Parameter 'value' implicitly has an 'any' type @definitelytyped/expect 2901:38 error TypeScript@local compile error: Parameter 'key' implicitly has an 'any' type @definitelytyped/expect 2901:43 error TypeScript@local compile error: Parameter 'collection' implicitly has an 'any' type @definitelytyped/expect 2902:9 error TypeScript@local expected type to be: AbcObject got: any @definitelytyped/expect 2903:9 error TypeScript@local expected type to be: string got: any @definitelytyped/expect 2904:9 error TypeScript@local expected type to be: NumericDictionary<AbcObject> got: any @definitelytyped/expect 2919:24 error TypeScript@local compile error: Parameter 'value' implicitly has an 'any' type @definitelytyped/expect 2919:31 error TypeScript@local compile error: Parameter 'index' implicitly has an 'any' type @definitelytyped/expect 2919:38 error TypeScript@local compile error: Parameter 'collection' implicitly has an 'any' type @definitelytyped/expect 2920:9 error TypeScript@local expected type to be: AbcObject got: any @definitelytyped/expect 2921:9 error TypeScript@local expected type to be: number got: any @definitelytyped/expect 2922:9 error TypeScript@local expected type to be: ArrayLike<AbcObject> || List<AbcObject> got: any @definitelytyped/expect 2927:30 error TypeScript@local compile error: Parameter 'value' implicitly has an 'any' type @definitelytyped/expect 2927:37 error TypeScript@local compile error: Parameter 'key' implicitly has an 'any' type @definitelytyped/expect 2927:42 error TypeScript@local compile error: Parameter 'collection' implicitly has an 'any' type @definitelytyped/expect 2928:9 error TypeScript@local expected type to be: AbcObject got: any @definitelytyped/expect 2929:9 error TypeScript@local expected type to be: string got: any @definitelytyped/expect 2930:9 error TypeScript@local expected type to be: Dictionary<AbcObject> got: any @definitelytyped/expect 2935:37 error TypeScript@local compile error: Parameter 'value' implicitly has an 'any' type @definitelytyped/expect 2935:44 error TypeScript@local compile error: Parameter 'key' implicitly has an 'any' type @definitelytyped/expect 2935:49 error TypeScript@local compile error: Parameter 'collection' implicitly has an 'any' type @definitelytyped/expect 2936:9 error TypeScript@local expected type to be: AbcObject got: any @definitelytyped/expect 2937:9 error TypeScript@local expected type to be: string got: any @definitelytyped/expect 2938:9 error TypeScript@local expected type to be: NumericDictionary<AbcObject> got: any @definitelytyped/expect 5619:5 error TypeScript@local expected type to be: CollectionChain<string> got: CollectionChain<any> @definitelytyped/expect 5619:43 error TypeScript@local compile error: Parameter 'val' implicitly has an 'any' type @definitelytyped/expect 5620:5 error TypeScript@local expected type to be: CollectionChain<string> got: CollectionChain<any> @definitelytyped/expect 5620:62 error TypeScript@local compile error: Parameter 'val' implicitly has an 'any' type @definitelytyped/expect ✖ 40 problems (40 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: yargs
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/yargs/yargs-tests.ts 1496:19 error TypeScript@local compile error: Parameter 'yargs' implicitly has an 'any' type @definitelytyped/expect 1504:19 error TypeScript@local compile error: Parameter 'argv' implicitly has an 'any' type @definitelytyped/expect ✖ 2 problems (2 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251105/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62725/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Git clone failed"

Otherwise...

Something interesting changed - please have a look.

Details

effect

packages/effect/benchmark/tsconfig.json

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 1 1 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,385 +15 (+ 0.02%) ~ ~ p=0.001 n=6
Types 50,386 50,401 +15 (+ 0.03%) ~ ~ p=0.001 n=6
Memory used 195,702k (± 0.76%) 194,507k (± 0.98%) ~ 192,657k 196,335k p=0.230 n=6
Parse Time 1.30s (± 0.69%) 1.29s (± 0.65%) ~ 1.28s 1.30s p=0.437 n=6
Bind Time 0.72s 0.72s ~ ~ ~ p=1.000 n=6
Check Time 9.86s (± 0.18%) 9.92s (± 0.28%) +0.06s (+ 0.57%) 9.89s 9.97s p=0.004 n=6
Emit Time 2.75s (± 0.63%) 2.69s (± 0.79%) -0.06s (- 2.18%) 2.67s 2.72s p=0.005 n=6
Total Time 14.63s (± 0.19%) 14.64s (± 0.23%) ~ 14.59s 14.68s p=0.936 n=6
angular-1 - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 956,047 954,922 -1,125 (- 0.12%) ~ ~ p=0.001 n=6
Types 415,881 416,125 +244 (+ 0.06%) ~ ~ p=0.001 n=6
Memory used 1,255,047k (± 0.00%) 1,255,444k (± 0.01%) +398k (+ 0.03%) 1,255,342k 1,255,534k p=0.005 n=6
Parse Time 6.48s (± 0.38%) 6.56s (± 1.02%) +0.07s (+ 1.13%) 6.49s 6.66s p=0.036 n=6
Bind Time 1.88s (± 0.43%) 1.88s (± 0.22%) ~ 1.87s 1.88s p=0.206 n=6
Check Time 32.33s (± 0.60%) 32.36s (± 0.36%) ~ 32.16s 32.51s p=0.520 n=6
Emit Time 14.94s (± 0.22%) 14.91s (± 0.26%) ~ 14.85s 14.96s p=0.169 n=6
Total Time 55.62s (± 0.37%) 55.71s (± 0.25%) ~ 55.55s 55.93s p=0.377 n=6
mui-docs - node (v18.15.0, x64)
Errors 1 1 ~ ~ ~ p=1.000 n=6
Symbols 552,568 552,568 ~ ~ ~ p=1.000 n=6
Types 89 89 ~ ~ ~ p=1.000 n=6
Memory used 827,090k (± 0.00%) 827,071k (± 0.00%) -19k (- 0.00%) 827,063k 827,081k p=0.037 n=6
Parse Time 8.37s (± 0.20%) 8.37s (± 0.22%) ~ 8.34s 8.39s p=1.000 n=6
Bind Time 2.18s (± 0.54%) 2.18s (± 0.37%) ~ 2.17s 2.19s p=0.498 n=6
Check Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Emit Time 0.28s 0.28s (± 1.47%) ~ 0.27s 0.28s p=0.405 n=6
Total Time 10.82s (± 0.15%) 10.83s (± 0.22%) ~ 10.79s 10.85s p=0.567 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,277 1,237,488 +211 (+ 0.02%) ~ ~ p=0.001 n=6
Types 259,883 260,579 +696 (+ 0.27%) ~ ~ p=0.001 n=6
Memory used 2,668,498k (±13.39%) 2,670,381k (±13.40%) ~ 2,366,215k 3,095,245k p=0.298 n=6
Parse Time 5.19s (± 1.31%) 5.20s (± 1.65%) ~ 5.11s 5.32s p=1.000 n=6
Bind Time 1.77s (± 1.23%) 1.77s (± 0.92%) ~ 1.75s 1.79s p=0.935 n=6
Check Time 35.21s (± 1.06%) 35.46s (± 1.13%) ~ 34.83s 35.90s p=0.298 n=6
Emit Time 3.04s (± 1.05%) 2.98s (± 1.62%) ~ 2.92s 3.03s p=0.078 n=6
Total Time 45.20s (± 0.88%) 45.41s (± 1.05%) ~ 44.72s 45.95s p=0.298 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,277 1,237,488 +211 (+ 0.02%) ~ ~ p=0.001 n=6
Types 259,883 260,579 +696 (+ 0.27%) ~ ~ p=0.001 n=6
Memory used 3,159,127k (± 0.05%) 3,040,012k (± 9.74%) ~ 2,435,237k 3,162,092k p=0.230 n=6
Parse Time 6.82s (± 0.65%) 6.81s (± 1.86%) ~ 6.56s 6.92s p=0.521 n=6
Bind Time 2.15s (± 0.72%) 2.17s (± 2.03%) ~ 2.12s 2.24s p=0.630 n=6
Check Time 42.84s (± 0.33%) 43.06s (± 0.72%) ~ 42.47s 43.32s p=0.093 n=6
Emit Time 3.53s (± 3.41%) 3.52s (± 2.55%) ~ 3.38s 3.61s p=0.630 n=6
Total Time 55.35s (± 0.36%) 55.56s (± 0.79%) ~ 54.72s 55.90s p=0.128 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,522 262,849 +327 (+ 0.12%) ~ ~ p=0.001 n=6
Types 104,048 104,234 +186 (+ 0.18%) ~ ~ p=0.001 n=6
Memory used 440,672k (± 0.02%) 441,251k (± 0.01%) +579k (+ 0.13%) 441,196k 441,311k p=0.005 n=6
Parse Time 3.51s (± 1.23%) 3.52s (± 0.84%) ~ 3.48s 3.57s p=0.745 n=6
Bind Time 1.32s (± 0.88%) 1.32s (± 1.12%) ~ 1.30s 1.34s p=0.680 n=6
Check Time 18.93s (± 0.37%) 19.09s (± 0.21%) +0.15s (+ 0.81%) 19.03s 19.15s p=0.005 n=6
Emit Time 1.53s (± 1.07%) 1.52s (± 1.08%) ~ 1.50s 1.54s p=0.321 n=6
Total Time 25.29s (± 0.45%) 25.45s (± 0.19%) +0.16s (+ 0.63%) 25.39s 25.53s p=0.016 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 72 72 ~ ~ ~ p=1.000 n=6
Symbols 225,386 225,416 +30 (+ 0.01%) ~ ~ p=0.001 n=6
Types 94,304 94,362 +58 (+ 0.06%) ~ ~ p=0.001 n=6
Memory used 370,044k (± 0.02%) 370,174k (± 0.02%) +130k (+ 0.03%) 370,103k 370,304k p=0.020 n=6
Parse Time 2.84s (± 1.23%) 2.83s (± 1.40%) ~ 2.79s 2.88s p=0.746 n=6
Bind Time 1.61s (± 1.21%) 1.61s (± 1.04%) ~ 1.59s 1.63s p=0.871 n=6
Check Time 16.52s (± 0.45%) 16.61s (± 0.31%) +0.09s (+ 0.52%) 16.54s 16.68s p=0.045 n=6
Emit Time 0.00s (±244.70%) 0.00s ~ ~ ~ p=0.405 n=6
Total Time 20.97s (± 0.46%) 21.05s (± 0.39%) ~ 20.96s 21.16s p=0.228 n=6
vscode - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 4,016,983 4,011,291 -5,692 (- 0.14%) ~ ~ p=0.001 n=6
Types 1,260,212 1,261,591 +1,379 (+ 0.11%) ~ ~ p=0.001 n=6
Memory used 3,798,276k (± 0.01%) 3,800,949k (± 0.01%) +2,674k (+ 0.07%) 3,800,572k 3,801,169k p=0.005 n=6
Parse Time 15.54s (± 0.84%) 15.54s (± 0.37%) ~ 15.44s 15.60s p=1.000 n=6
Bind Time 5.04s (± 0.32%) 5.03s (± 0.98%) ~ 4.97s 5.12s p=0.459 n=6
Check Time 105.01s (± 4.57%) 107.07s (± 4.09%) ~ 101.91s 113.41s p=0.575 n=6
Emit Time 42.42s (±10.03%) 39.27s (±22.57%) ~ 31.39s 53.14s p=0.378 n=6
Total Time 168.00s (± 3.86%) 166.90s (± 6.30%) ~ 159.65s 187.18s p=0.336 n=6
webpack - node (v18.15.0, x64)
Errors 40 40 ~ ~ ~ p=1.000 n=6
Symbols 379,164 379,398 +234 (+ 0.06%) ~ ~ p=0.001 n=6
Types 166,355 166,555 +200 (+ 0.12%) ~ ~ p=0.001 n=6
Memory used 537,994k (± 0.00%) 538,245k (± 0.03%) +250k (+ 0.05%) 537,975k 538,484k p=0.045 n=6
Parse Time 4.66s (± 0.59%) 4.60s (± 0.54%) -0.06s (- 1.22%) 4.57s 4.63s p=0.010 n=6
Bind Time 1.94s (± 0.76%) 1.94s (± 0.65%) ~ 1.93s 1.96s p=0.866 n=6
Check Time 22.63s (± 0.15%) 22.75s (± 1.15%) ~ 22.51s 23.26s p=0.230 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 29.22s (± 0.13%) 29.29s (± 0.82%) ~ 29.05s 29.75s p=0.467 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 32 🔻+2 (+ 6.67%) ~ ~ p=0.001 n=6
Symbols 690,485 700,194 +9,709 (+ 1.41%) ~ ~ p=0.001 n=6
Types 208,757 212,235 +3,478 (+ 1.67%) ~ ~ p=0.001 n=6
Memory used 586,527k (± 0.03%) 592,954k (± 0.03%) +6,426k (+ 1.10%) 592,784k 593,198k p=0.005 n=6
Parse Time 4.18s (± 0.88%) 4.17s (± 1.02%) ~ 4.14s 4.25s p=0.624 n=6
Bind Time 1.33s (± 1.32%) 1.33s (± 0.74%) ~ 1.32s 1.34s p=0.866 n=6
Check Time 20.65s (± 1.74%) 20.96s (± 1.73%) ~ 20.61s 21.35s p=0.173 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 26.16s (± 1.31%) 26.47s (± 1.28%) ~ 26.10s 26.81s p=0.173 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62725/merge:

Something interesting changed - please have a look.

Details

reduxjs/reselect

4 of 6 projects failed to build with the old tsc and were ignored

typescript_test/tsconfig.json

type-tests/tsconfig.json

RSSNext/Folo

14 of 18 projects failed to build with the old tsc and were ignored

packages/internal/store/tsconfig.json

packages/internal/database/tsconfig.json

trpc/trpc

36 of 42 projects failed to build with the old tsc and were ignored

packages/react-query/tsconfig.json

@Andarist Andarist marked this pull request as draft November 6, 2025 07:35
@Andarist
Copy link
Contributor Author

Andarist commented Nov 6, 2025

Repros:

  • one of the reselect's one: TS playground. Overloads somehow throw a wrench in here, note that state parameter is being contextually typed with any originally too - but with this PR it's an implicit any
  • one of the Folo's breaks that is actually a Drizzle ORM break: TS playground. It's overloads-related again. My intuition says that it's very likely it would just work if the compiler would have this. I'll think what can be done to mitigate this here without it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

3 participants