Avoid redundant work in _compute_single_neighbor_list for full neighbor list #788
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This avoids doing unnecessary work if a full neighborlist is requested -- we don't have to filter for half first, then restore.
With the attached benchmark script (run.py), on my MacBook (M3 Max), with the first number the timing for
_compute_single_neighbor_list, and the second for a plain call tovesin:before
after
This is an about 30% improvement in execution time.
Contributor (creator of pull-request) checklist
Maintainer/Reviewer checklist