Skip to content

Update main.js #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update main.js #81

wants to merge 1 commit into from

Conversation

@Akiyamka
Copy link

@Akiyamka Akiyamka commented Nov 8, 2024

Summary

Unnecessary code removed.

  • No need to declare the 'self' variable - we already have 'this' for this purpose
  • No need to declare a constructor - JavaScript will call super automatically if no constructor is declared
  • No need to convert the node list to an array - we have 'for' loops that can iterate over node lists directly
@Akiyamka
Update main.js
d70c54d 
Unnecessary code removed. No need to declare the 'self' variable - we already have 'this' for this purpose No need to declare a constructor - JavaScript will call super automatically if no constructor is declared No need to convert the node list to an array - we have 'for' loops that can iterate over node lists directly
@bsmth
Copy link
Member

bsmth commented Mar 28, 2025

Thanks for the submission! @wbamberg you touched these last, do you want to have a quick look?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Akiyamka @bsmth