Skip to content

Major refactor - Fixes many bugs - New features - Cleaned! #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
majkelowskiii merged 18 commits into from
Jun 29, 2024
Merged

Major refactor - Fixes many bugs - New features - Cleaned! #3

majkelowskiii merged 18 commits into from
Jun 29, 2024

Conversation

@CodeByAidan
Copy link
Contributor

@CodeByAidan CodeByAidan commented Jun 29, 2024

No description provided.

CodeByAidan added 18 commits June 29, 2024 16:54
@CodeByAidan
basic formatting
a17e1a3
@CodeByAidan
use constant variables tto simplify the paths and directories
9243734
@CodeByAidan
added the code to grab/update the ratings automatically and added a p…
a32ebff 
…ydantic model to validate the data.
@CodeByAidan
Hoisted a lot of excessive code, and verbose/robust it.
8332fde
@CodeByAidan
Hoisted a lot of duplicate code
ca32b7a
@CodeByAidan
don't import with a wildcard (other than tkinter)
3691ce2
@CodeByAidan
replace comparison with min/max call
b40e283
@CodeByAidan
replace comparison with min/max call
b77cf27
@CodeByAidan
Use f-string instead of string concatenation, remove unnecessary call…
6efd45e 
…s to `str()` from formatted values in f-strings
@CodeByAidan
Remove redundant pass statement
d8f2bd7
@CodeByAidan
Simplify chained comparison between the operands
209ca33
@CodeByAidan
**Add a nested comment explaining why this method is empty, or comple…
11abc1d 
…te the implementation**
@CodeByAidan
Comparison 'temp_df['premium'] == False' should be 'not temp_df['prem…
ef1202d 
…ium']' if testing for falsiness
@CodeByAidan
fixed bug when you don't have any value for ID it hits ValueError
80bd2c2
@CodeByAidan
added some type annotations
f714dc2
@CodeByAidan
snake_case naming style
1c415d4
@CodeByAidan
Use driver code for the main method of a script
f3c0d4c
@CodeByAidan
added a bit more robustness to make sure this script runs from anywhe…
626278d 
…re, stops when it hits an error, validationerror is handled, etc. and updated the data
@majkelowskiii majkelowskiii merged commit 9a0a590 into majkelowskiii:main Jun 29, 2024
@majkelowskiii
Copy link
Owner

majkelowskiii commented Jun 29, 2024

@CodeByAidan hi 👋 - thank you for contributing, I have had some break from developing this project and switched more to the user side :)
How have you encounter that repo? Maybe have you had a chance to use it? Or just randomly popped into it and decided to refactor/contribute? 🤠
@CodeByAidan
Copy link
Contributor Author

CodeByAidan commented Jun 30, 2024

Honestly I forgot why I stumbled upon your repository, other than the fact that I was searching for a API wrapper for Leetcode, since I made something a while ago to scrape descriptions for Leetcode and export it to a file. I honestly forget, but one of the first results for "Leetcode wrapper API", was your repository! So I decided to refactor it since it needed a bit of love to it, and also there's no algorithm previously to download the reviews.txt, so adding that was nice. Now it's easy to add your future commit!
@majkelowskiii
Copy link
Owner

majkelowskiii commented Jun 30, 2024

Thank you once again :)
I have such automatic refresh of rankings in mind, but was not aware of raw.githubusercontent was a thing 😁
Take care 🤠
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@CodeByAidan @majkelowskiii