Skip to content

refactor: separate Button component #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2020
Merged

refactor: separate Button component #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions packages/styled-components/src/components/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from 'react'
import styled from 'styled-components'
import { color } from '../styles'
import { Header } from './Header'
import { Button } from './Button'

const CustomButton: React.FC = ({ children }) => <button onClick={() => alert('CustomButton')}>{children}</button>

Expand All @@ -24,13 +25,6 @@ const Container = styled.div({
justifyContent: 'center',
})

const Button = styled.button`
border: solid 1px ${color.primary};
width: 100px;
height: 30px;
margin: 0 20px;
`

type StyleMap = {
[key: string]: () => string
}
Expand Down Expand Up @@ -60,4 +54,3 @@ const StyleObjectsStyledButton = styled(Button)<StyleButtonProps>(
},
(props) => (props.styleType ? styleMap[props.styleType]() : styleMap.default())
)

18 changes: 18 additions & 0 deletions packages/styled-components/src/components/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import styled from 'styled-components'
import { color } from '../styles'

export const Button = styled.button`
border: solid 1px ${color.primary};
width: 100px;
height: 30px;
margin: 0 20px;
`

// Style Objects
const StyleObjectsButton = styled.button({
border: `solid 1px ${color.primary}`,
width: 100,
height: 30,
margin: '0 20px',
})