Persist agreed quotes in RFQ service #1863
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
darioAnongba force-pushed the feat/persist-rfq branch from 3c33ca3 to f0acc02 Compare 
Pull Request Test Coverage Report for Build 19360530476Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 19038516198Details
💛 - Coveralls |
darioAnongba force-pushed the feat/persist-rfq branch 2 times, most recently from 98bcb62 to 5a2bd52 Compare 
GeorgeTsagk reviewed Nov 5, 2025
ffranr reviewed Nov 10, 2025
darioAnongba force-pushed the feat/persist-rfq branch from 5a2bd52 to f7ebd34 Compare darioAnongba force-pushed the feat/persist-rfq branch from f7ebd34 to 703a103 Compare darioAnongba force-pushed the feat/persist-rfq branch 3 times, most recently from e74f4ab to 497b820 Compare darioAnongba force-pushed the 0-8-0-staging branch from 2b3ac4f to 035a840 Compare 
Adds a new rfq_policies table and store allowing persistence of sale and purchase policies.
darioAnongba force-pushed the feat/persist-rfq branch from 497b820 to 7beb886 Compare GeorgeTsagk reviewed Nov 17, 2025
Member
GeorgeTsagk left a comment
GeorgeTsagk left a comment There was a problem hiding this comment.
Just a few nits, will do a final pass soon
| @@ -0,0 +1,20 @@ | |||
| package rfq | |||
Member
There was a problem hiding this comment.
nit: file should be named policy_store.go
| | ||
| // cleanupStalePolicies removes expired policies from the local cache. | ||
| func (h *OrderHandler) cleanupStalePolicies() { | ||
| func (h *OrderHandler) cleanupStalePolicies() error { |
Member
There was a problem hiding this comment.
you only seem to return nil here, why not remove error?
darioAnongba moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
RFQ buy/sell accepts are now written to the database (
rfq_policiestable) whenever a policy is agreed, giving us an audit trail and keeping quotes across restarts.The
OrderHandlerreloads these rows at startup to rebuild policies and the manager repopulates its in-memory caches from the same data.Added a check in
itestthat restarts Bob’stapdmid RFQ flow and verifies the quote remains available to Carol.Fixes #855