Zero fee commitment test vectors #4202
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
To be used in the commits that follow for zero fee commitment test vectors.
In v3 test vectors, we're using real preimages so won't be able to use the workaround here.
| 👋 Thanks for assigning @tankyleo as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #4202 +/- ## ========================================== + Coverage 89.28% 89.29% +0.01% ========================================== Files 180 180 Lines 137913 137913 Branches 137913 137913 ========================================== + Hits 123134 123154 +20 + Misses 12163 12149 -14 + Partials 2616 2610 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Needs some serious cleaning up, so please don't review yet!
Opening up early because I'll be out till the 10th, want to have a passing version of these up in the meantime.