Skip to content

Conversation

@nunomaduro
Copy link
Member

This pull request should ideally target an new version of Laravel Pint, that should ship by default in Laravel 10.x. Please check laravel/laravel#6010 for details about this pull request.

@timacdonald
Copy link
Member

timacdonald commented Dec 22, 2022

@nunomaduro I wonder if we care about "dynamic" parameters, which we have used to introduce new features without breaking function signatures in laravel/framework

Although not a common occurrence, we have just done that recently.

See $throwCallback here: https://github.com/laravel/framework/pull/45251/files#diff-1ac9aa0ab55e04c899a86ef074016e5ebc3683e3e90101f03284305301771067R609-R619

I would imagine this would strip the param. I know we don't use pint on the framework and instead use StyleCI, but just a thought for consideration.

We may want to use allow_unused_params => true if we want consistency with the framework itself.

@zepfietje
Copy link
Contributor

@nunomaduro @timacdonald, is this still something to be shipped with the initial release of Laravel 10?

@nunomaduro nunomaduro force-pushed the feat/no-superfluous-phpdoc-tags branch from 8e8e600 to 3622623 Compare February 8, 2023 13:39
@nunomaduro nunomaduro marked this pull request as ready for review February 8, 2023 17:21
@nunomaduro nunomaduro changed the title [2.x] Removes superfluous annotations [1.x] Removes superfluous annotations Feb 8, 2023
@taylorotwell taylorotwell merged commit 7a07930 into main Feb 8, 2023
@taylorotwell taylorotwell deleted the feat/no-superfluous-phpdoc-tags branch February 8, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants