Skip to content

[9.x] Add missing method to View/ComponentAttributeBag #45016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 18, 2022
Merged

[9.x] Add missing method to View/ComponentAttributeBag #45016

merged 4 commits into from
Nov 18, 2022

Conversation

ProjektGopher
Copy link
Contributor

Simple quality-of-life/legibility improvement for checking if an attribute is missing from the ComponentAttributeBag.

- if ($override instanceof ComponentAttributeBag && !$override->has('class')) { + if ($override instanceof ComponentAttributeBag && $override->missing('class')) { return $base; }
@ProjektGopher ProjektGopher changed the title Feature (non-breaking): add missing method to View/ComponentAttributeBag [9.x] Add missing method to View/ComponentAttributeBag Nov 18, 2022
@taylorotwell taylorotwell merged commit 81ea922 into laravel:9.x Nov 18, 2022
@ProjektGopher ProjektGopher deleted the feat/view-component-attribute-bag-missing branch November 18, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ProjektGopher @taylorotwell