[9.x] Add support for multiple hash algorithms #43407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
driesvints reviewed Jul 25, 2022
| * @return string | ||
| */ | ||
| public function hash($path) | ||
| public function hash($path, $algorithm = 'md5') |
There was a problem hiding this comment.
This is a breaking change to the method signature unfortunately.
There was a problem hiding this comment.
I had done PR for version v10, but they asked to do it for v9.
Let me know if I need to change anything.
| I think this is probably OK - unlikely it was being overwritten. |
Ken-vdE pushed a commit to Ken-vdE/framework that referenced this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We often need the
sha256of the file, it would be interesting forFilesystemto get it.I was always confused by the original implementation, as "hash" refers me to all sorts of algorithms. That way we don't break what already exists (md5 default) and enable hashing like sha256 or sha512.
https://www.php.net/manual/en/function.hash-algos.php