This repository was archived by the owner on Dec 3, 2024. It is now read-only.
Fix reconciliation logic for existing and deleted objects #139
+75 −42
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR addresses two cases:
Controller Restarts:
When the controller restarts, it does not handle deletions for removed objects.
Specifically, when an object with a deletion timestamp is passed into the Add() method, the deletion process was not handled correctly.
Recreation of Objects:
The recreation of objects is not functioning as expected. For example, when an object is created, deleted, and then created again.
In this scenario, the object may enter the Update method, where the creation process was not being handled properly.