fix some bug fixes

[kobi97]

Hello krowinski

I found two bugs. (in mariadb-10.0.26)

1. BinlogSocketConnect refactoring error
   -> mariadb is not working. so I fixed it.

2. Binlog_checksum 's result
   I didn't use it but I found this problem. Just check below site.
   MySQL 5.6.2 --binlog-checksum={NONE|CRC32}
   https://dev.mysql.com/doc/refman/5.6/en/replication-options-binary-log.html

Thanks for reading and your new v3.0.0 release. :)

[krowinski]

Hi, can you send me your configuration ? gtid should be used only with percona or generic mysql maria db have diffrent gtid and its have dedictated method in confiuration.

I will check rest tx!

[kobi97]

This is my configurations.

// mariadb:10.0.27 $binlog_connect_array = [	'ip' => '127.0.0.1',	'port' => 3307,	'user' => 'repl',	'password' => '1234',	'charset' => 'utf8',	'slaveId' => '999',	'mariaDbGtid' => '0-2-7130' ]; (new ConfigFactory())->makeConfigFromArray($binlog_connect_array); $binlog_stream = new MySQLReplicationFactory(); $binlog_stream->registerSubscriber(new GetInitBinlogDateSubscriber()); while (true) {	$binlog_stream->consume(); } 

I guess this is refactoring problems.
check below v2.2.0 code.

https://github.com/krowinski/php-mysql-replication/blob/v2.2.0/src/MySQLReplication/BinLog/BinLogSocketConnect.php#L242

https://github.com/krowinski/php-mysql-replication/blob/master/src/MySQLReplication/BinLog/BinLogSocketConnect.php#L239

In case of use mariadbGtid in v3.0.0, below code is not executed.

setBinLogDump(); 

Thanks for Reading :)

[krowinski]

ok you are right I forgot that mariadb have strange gtid that first you set gtid marker then use normal binlogdump.

Tx!