Skip to content

Conversation

@antonio081014
Copy link
Contributor

@antonio081014 antonio081014 commented Apr 24, 2017

Checklist

Description

This PR added more implementation of UnionFind algorithms with complexity analysis added by the end of README file.

@antonio081014
Copy link
Contributor Author

@kelvinlauKL, @vincentngo Any maintainers available to take a look at this PR?

@kelvinlauKL kelvinlauKL self-assigned this May 4, 2017
@kelvinlauKL
Copy link
Member

kelvinlauKL commented May 6, 2017

@antonio081014

This looks good, but I just wanted a clarification on something.

You used the word variety. I'm not familiar with this usage in this context. Did you mean to write a "variant of the implementation"?

@antonio081014
Copy link
Contributor Author

Yes, have each implementation in a single swift file. These implementations demonstrate how this algorithm could be improved or implemented in some other way.

@kelvinlauKL
Copy link
Member

Cool. This looks good to merge. Thanks!

@kelvinlauKL kelvinlauKL merged commit 625a97e into kodecocodes:master May 7, 2017
@antonio081014 antonio081014 deleted the UnionFindMoreImplementation branch May 23, 2017 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants