Update Binary search tree #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
weihanglo commented Feb 4, 2017
weihanglo commented - Fix Issue: left/right tree should reconnect to new node
- Test: unmark .travis.yml test
- Lint files
- Update README.markdown
kelvinlauKL reviewed Feb 4, 2017
Member
kelvinlauKL left a comment
kelvinlauKL left a comment There was a problem hiding this comment.
Most changes look good. I'd like to discuss more on the remove method changes.
| if let left = left { | ||
| replacement = left.maximum() | ||
| } else if let right = right { | ||
| if let right = right { |
Member
There was a problem hiding this comment.
What's the significance of handling the right child before the left?
Contributor Author
There was a problem hiding this comment.
The previous version before 942e3b1 use successor to replace the node with 2 children. The unit tests are also based on this logic. I am kind of lazy to modify all the test cases 😵.
Member
There was a problem hiding this comment.
Alright cool. I think this checks out. Merging!
Member
| Thanks @weihanglo! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.