refactor: replace emoji-regex with emoji-regex-xs #1048
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ljharb requested changes Apr 18, 2025
Member
ljharb left a comment
ljharb left a comment There was a problem hiding this comment.
It looks good at a glance, but using it is blocked on slevithan/emoji-regex-xs#4
Author
| After reading through |
| @ljharb Can you confirm that you do not want to use it if it requires (7 years old) Node.js 10? |
Member
| Unfortunately yes, currently this package requires node 4 support. |
| No worries. Thanks for confirming. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Overview
This pull request replaces
emoji-regexwithemoji-regex-xspackage that has 97% smaller size while maintaining its API and features.