remove polyfills #1020
Merged
remove polyfills #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
talentlessguy changed the title 
ljharb force-pushed the remove-polyfills branch from 9be0d02 to 9dbfba3 Compare 
Member
| I pushed up my in-progress |
ljharb changed the title Member
| (don't worry about the test failures; i think they're coming from the |
ljharb force-pushed the remove-polyfills branch from 10ff040 to 6afe41c Compare 
MichaelDeBoey approved these changes Oct 25, 2024
MichaelDeBoey suggested changes Oct 25, 2024
MichaelDeBoey approved these changes Oct 25, 2024
ljharb force-pushed the breaking branch 3 times, most recently from 332fecc to 9dd2253 Compare ljharb force-pushed the remove-polyfills branch from 6afe41c to dddca6f Compare 
ljharb approved these changes Oct 25, 2024
Member
ljharb left a comment
ljharb left a comment There was a problem hiding this comment.
rebased, and will merge into the breaking branch. thanks!
MichaelDeBoey approved these changes Oct 25, 2024
Co-authored-by: v1rtl <hi@v1rtl.site> Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
| New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/flow-bin@0.147.0 |
MichaelDeBoey suggested changes Oct 25, 2024
Contributor Author
| @ljharb @MichaelDeBoey CI is green now, safe to merge? |
ljharb force-pushed the remove-polyfills branch from 23bffc0 to 9ff0f5f Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
TODO:
this PR also bumps minimum Node version to 18 and ESLint to 8 (both in GHA and package.json)