Skip to content

fix(radio-group): emit value change on componentDidLoad #28488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2023
Merged

fix(radio-group): emit value change on componentDidLoad #28488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36700d7
fix(radio-group): emit value change on componentDidLoad
thetaPC Nov 8, 2023
cf8c59d
fix(radio-group): add comment
thetaPC Nov 9, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/src/components/radio-group/radio-group.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,16 @@ export class RadioGroup implements ComponentInterface {
@Event() ionValueChange!: EventEmitter<RadioGroupChangeEventDetail>;

componentDidLoad() {
this.setRadioTabindex(this.value);
/**
* There's an issue when assigning a value to the radio group
* within the Angular primary content (rendering within the
* app component template). When the template is isolated to a route,
* the value is assigned correctly.
* To address this issue, we need to ensure that the watcher is
* called after the component has finished loading,
* allowing the emit to be dispatched correctly.
*/
this.valueChanged(this.value);
}

private setRadioTabindex = (value: any | undefined) => {
Expand Down