Skip to content

Add the pthread linkage while verifying the build [HZ-5191] #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 1, 2025
Merged

Add the pthread linkage while verifying the build [HZ-5191] #1348

merged 7 commits into from
Nov 1, 2025

Conversation

@ihsandemir
Copy link
Collaborator

@ihsandemir ihsandemir commented Oct 31, 2025 •
edited
Loading

Added the pthread linkage while verifying the build. 32-bit linux builds were failing due to this.

Example green build at here:
@ihsandemir
Added the pthread linkage for examples build which is needed for 32-b…
f329810 
…it builds. I added it for all builds of the examples even though it may be automatically added for other than 32-bit linux builds.
@ihsandemir
Added github ref for checkout.
ed0fb61
@ihsandemir
linking pthread explicitly.
2cad673
@ihsandemir
Added commit hash to checkouts as an input to workflows so that the b…
8cb55a3 
…uilds can run on any commit or branch. Default behaviour is still to use master branch checkout.
@ihsandemir ihsandemir added this to the 5.5.0 milestone Oct 31, 2025
@ihsandemir ihsandemir requested a review from JackPGreen October 31, 2025 20:06
@ihsandemir ihsandemir self-assigned this Oct 31, 2025
@JackPGreen
Copy link
Contributor

JackPGreen commented Oct 31, 2025

Also added workflow input parameter commit ref.

Why did we need this?
@ihsandemir ihsandemir enabled auto-merge (squash) October 31, 2025 20:48
@ihsandemir
Copy link
Collaborator Author

ihsandemir commented Oct 31, 2025

Also added workflow input parameter commit ref.

Why did we need this?

I needed to be able to run the workflow on my fıx branch and hence I needed that we checkout a certaın branch for the testing of the PR change.
@JackPGreen
Copy link
Contributor

JackPGreen commented Oct 31, 2025

Also added workflow input parameter commit ref.

Why did we need this?

I needed to be able to run the workflow on my fıx branch and hence I needed that we checkout a certaın branch for the testing of the PR change.

You should be able to do that already? If you run the workflow from your branch it should implicitly use the branch as source.
@ihsandemir
Copy link
Collaborator Author

ihsandemir commented Oct 31, 2025

Also added workflow input parameter commit ref.

Why did we need this?

I needed to be able to run the workflow on my fıx branch and hence I needed that we checkout a certaın branch for the testing of the PR change.

You should be able to do that already? If you run the workflow from your branch it should implicitly use the branch as source.

You are right. I reverted back. See 5565ab5
@ihsandemir ihsandemir changed the title Add the pthread linkage while verifying the build - Add workflow input parameter commit ref [HZ-5191] Add the pthread linkage while verifying the build [HZ-5191] Nov 1, 2025
@ihsandemir ihsandemir merged commit 49c525b into master Nov 1, 2025
46 checks passed
@ihsandemir ihsandemir deleted the 32bit_thread_fix branch November 1, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Enhancement

3 participants

@ihsandemir @JackPGreen