Skip to content

Bumped source and target compatibility to Java 1.8 #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Bumped source and target compatibility to Java 1.8 #332

wants to merge 7 commits into from

Conversation

@peterdemaeyer
Copy link
Contributor

@peterdemaeyer peterdemaeyer commented Feb 21, 2021

No description provided.

@peterdemaeyer
Copy link
Contributor Author

peterdemaeyer commented Feb 21, 2021

The Travis build with Java 1.7 will fail of course.
@nik9000
Copy link

nik9000 commented May 14, 2021

I'm just someone random in the internet, but this looks like a good change to me. Maybe drop the java 7 config from Travis in this pr too?

The raw types make me sad, but it's a small price to pay for it to be much much easier to contribute.

From a purely semver standpoint this is a breaking change, I think. But I imagine most folks are off of 7. I'm not even sure how to download it at this point....
@peterdemaeyer
Copy link
Contributor Author

peterdemaeyer commented Sep 2, 2021 •
edited
Loading

Maybe drop the java 7 config from Travis in this pr too?

I removed the Java 7 Travis build configuration.
@peterdemaeyer
Copy link
Contributor Author

peterdemaeyer commented Sep 7, 2021 •
edited
Loading

It seems that Travis CI has moved from .org to .com, so builds are no longer working.
As a workaround, I set up my own Travis for my fork, but now Oracle JDK builds are failing.
@rjmunro
Copy link
Contributor

rjmunro commented Sep 8, 2021 •
edited
Loading

Ideally there would be a last release compatible with Java 7, with whatever we have now, then this 1.8 bump can be merged and a whole pile of new Java 8 features can be added.
@nhojpatrick
Copy link
Member

nhojpatrick commented Feb 13, 2022

Going to try and kick start hamcrest, so if you want to get it merged, please rebase from the branch feature/v3.x-ea.
Still trying to understand how has permissions to perform a release.
Looking to keep v2.x as java 7, with v3 bumping to java 8.
@nhojpatrick nhojpatrick force-pushed the master branch 2 times, most recently from 9bc653b to e9f7fc8 Compare February 13, 2022 17:06
@tumbarumba
Copy link
Member

tumbarumba commented Jul 24, 2024

Fixed in #411
@tumbarumba tumbarumba closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@peterdemaeyer @nik9000 @rjmunro @nhojpatrick @tumbarumba