add logs to grpclb on send and recv #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dfawley approved these changes May 12, 2017
Member
dfawley left a comment
dfawley left a comment There was a problem hiding this comment.
A couple optional changes, otherwise LGTM
| }, | ||
| } | ||
| if err := stream.Send(initReq); err != nil { | ||
| grpclog.Printf("grpclb: failed to send init request: %v", err) |
| ClientStats: &stats, | ||
| }, | ||
| }); err != nil { | ||
| grpclog.Printf("grpclb: failed to send load report: %v", err) |
Member
There was a problem hiding this comment.
Should we also log the request?
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.